Skip to content

fix(platform): platform selector focus loss on non platform pages #12703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix(platform): platform selector focus loss on non platform pages #12703

merged 1 commit into from
Feb 13, 2025

Conversation

@a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Feb 13, 2025 •
edited
Loading

fix an issue with the platform selector on non platform pages where it loses focus after two keystrokes

@vercel
Copy link

vercel bot commented Feb 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 11:49am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 11:49am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 11:49am

@a-hariti a-hariti requested a review from chargome February 13, 2025 11:40
@codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 5 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.93MB 1 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.39MB 4 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/chunks/4744-*.js 10 bytes 42.12kB 0.02%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/lggrLTLCh3jSbEa2INS0N/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/lggrLTLCh3jSbEa2INS0N/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/1TwbHZ3GJaE-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/1TwbHZ3GJaE-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/4744-*.js:

  • ./src/components/platformSelector/index.tsx → Total Size: 19.66kB
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
1054.js 10 bytes 81.42kB 0.01%

Files in 1054.js:

  • ./src/components/platformSelector/index.tsx → Total Size: 18.59kB

  • ./src/components/platformSelector/index.tsx → Total Size: 490 bytes

chargome
chargome approved these changes Feb 13, 2025
View reviewed changes
src/components/platformSelector/index.tsx
);
const showStoredPlatform =
!isPlatformPage && storedPlatformKey && storedPlatform && path !== '/platforms/';
!open &&
Copy link
Member

@chargome chargome Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧠

@chargome chargome changed the title fix platform selector focus lost on non platform pages fix(platform): platform selector focus lost on non platform pages Feb 13, 2025
@a-hariti a-hariti changed the title fix(platform): platform selector focus lost on non platform pages fix(platform): platform selector focus loss on non platform pages Feb 13, 2025
@a-hariti a-hariti merged commit 451212a into master Feb 13, 2025
13 checks passed
@a-hariti a-hariti deleted the platform-selector-race-condition branch February 13, 2025 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chargome chargome chargome approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@a-hariti @chargome